Skip to content

Conversation

thompson-tomo
Copy link

@thompson-tomo thompson-tomo commented Jun 11, 2025

Fixes #151

Changes

  • bump the resource packages to the lowest version which has added support for net standard.
  • bump the aws package to the first stable version
  • bump the aws lamba package the first stable version so that it is included on net framework & net standard

Merge requirement checklist

  • Unit tests added/updated
  • CHANGELOG.md file updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@thompson-tomo thompson-tomo requested a review from a team as a code owner June 11, 2025 10:42
@CLAassistant
Copy link

CLAassistant commented Jun 11, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@martincostello
Copy link
Member

Thanks for your pull request @thompson-tomo.

I already have a pull request inflight to update the versions of all of our dependences to the latest versions: #145

There are some considerations to make regarding dependencies we need to consider (which are noted in that PR's description) regarding the version(s) from transient dependencies that come with the updates.

We might be able to take this in the meantime, I'll need to take through a look through the whole dependency tree to check it doesn't cause any issues. I assume you've taken a look at that to some degree due to the fact you've moved to 1.10.* versions for all the other packages, but going to 1.11.0 for AWS Lambda might be too far, and we'd need to stay on the latest prerelease for 1.10.x instead.

@thompson-tomo
Copy link
Author

So I focussed very much on the lowest versions which was either a stable version or added a new TFM.

One thing I notice with your pr is that you have not adjusted the conditions on the dependencies.

@martincostello
Copy link
Member

One thing I notice with your pr is that you have not adjusted the conditions on the dependencies.

No, mainly because I didn't notice. But also that PR is currently in draft pending a decision on how to proceed with regards to the comments regarding transient versions.

@martincostello
Copy link
Member

FYI the linked PR has adjusted the groups in a similar manner to here.

@martincostello
Copy link
Member

Thanks again for your pull request - I'm going to close this as we're going to go with merging #145.

@thompson-tomo thompson-tomo deleted the patch-1 branch July 17, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update packages where new TFM enables condition removal

3 participants